next-mypy fixes azure-ai-ml sdk #44132
Open
+157
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZubaeyrMSFT
requested review from
nick863,
novaturient95,
raduk,
rtanase and
sharma-riti
as code owners
Copilot finished reviewing on behalf of
ZubaeyrMSFT
November 21, 2025 14:16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses mypy 1.18.1 type checking issues in the azure-ai-ml SDK by adding Optional type hints to setter parameters in AutoML entity classes. This is the first in a series of PRs fixing 16 out of 73 mypy errors, specifically targeting automl entities where setter parameters can accept None values but were not annotated as Optional.
Key changes:
- Added
Optionaltype annotations to setter parameters across training settings, featurization settings, and job classes - Updated corresponding documentation in automl_image_classification_base.py to reflect the Optional type
- Added
TrainingSettingsimports to job files to support more flexible typing
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| training_settings.py | Added Optional to setter parameters for allowed_training_algorithms and blocked_training_algorithms in Classification, Forecasting, and Regression training settings classes |
| regression_job.py | Updated training setter type hint to accept Union[Dict, TrainingSettings] and added TrainingSettings import |
| forecasting_job.py | Updated training setter type hint to accept Union[Dict, TrainingSettings] and added TrainingSettings import |
| classification_job.py | Updated training setter type hint to accept Union[Dict, TrainingSettings] (import already present) |
| featurization_settings.py | Added Optional to transformer_params and blocked_transformers setter parameters |
| automl_nlp_job.py | Added Optional to training_parameters setter parameter |
| automl_image_object_detection_base.py | Added Optional to training_parameters setter parameter |
| automl_image_classification_base.py | Added Optional to training_parameters setter parameter and updated corresponding docstring type annotation |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/training_settings.py
Show resolved
Hide resolved
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/automl/training_settings.py
Show resolved
Hide resolved
ZubaeyrMSFT
requested review from
achauhan-scc,
jayesh-tanna,
kingernupur and
paulshealy1
as code owners
ZubaeyrMSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ISSUE: #43513 azure-ai-ml needs typing updates for mypy version 1.18.1
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines